Skip to content

fix(ci): fix actionlint CI failure and test.yml SHA corruption#175

Merged
YiWang24 merged 1 commit into
mainfrom
fix/clean-actionlint
May 26, 2026
Merged

fix(ci): fix actionlint CI failure and test.yml SHA corruption#175
YiWang24 merged 1 commit into
mainfrom
fix/clean-actionlint

Conversation

@YiWang24

@YiWang24 YiWang24 commented May 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixes two issues found in CI:

1. actionlint false positives in ci-self-test

Root cause: The actionlint job vends .openci/ from a pinned SHA via resolve-openci. When the top-level workflow files reference newer action input names than what exists in the older vendored composite actions, actionlint reports "input not defined" errors.

Fix: Remove the resolve-openci vendoring step from the actionlint job. Actionlint only needs to check the current source files — the vendored .openci/ at a different SHA introduces false positives.

2. test.yml text corruption

Root cause: An earlier version of bump-self-sha.sh used awk '{print $NF}' to extract the old SHA from manifest.yml. On the line YiAgent/OpenCI: "sha" # resolve-openci bootstrap, awk extracted bootstrap instead of the SHA. The perl substitution then replaced bootstrap with the full 40-char SHA, corrupting bootstrapping into a SHA string in 4 locations.

Fix: Restored the original bootstrapping text in all comments, descriptions and step names.

Files Changed

  • .github/workflows/reusable-self-test.yml — Remove resolve-openci from actionlint job (+ SHA sync)
  • .github/workflows/test.yml — Fix 4 corrupted text instances

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag @codesmith with what you need. Autofix is disabled.

Greptile Summary

This PR addresses two separate CI problems: false-positive actionlint errors caused by vendoring an older composite-action SHA into the lint job, and four text corruptions in test.yml where the word "bootstrapping" was replaced with a 40-character SHA by a faulty awk field extractor in bump-self-sha.sh.

  • reusable-self-test.yml: Drops the resolve-openci step from the actionlint job so the tool validates workflows against the current composite actions rather than an older vendored copy. The pinned SHA in the three remaining resolve-openci steps is advanced to 0fc8c784 (the PR base commit).
  • test.yml: Restores "bootstrapping" in four locations — the file header comment, body comment, workflow_dispatch input description, and step name — all of which were overwritten by the SHA bump script reading the wrong awk field.

Confidence Score: 5/5

Both changes are safe to merge — one removes a step that caused false positives, the other restores text that was mechanically corrupted.

The actionlint job change is a targeted removal of a vendoring step whose only effect was injecting stale composite-action definitions into the linter's view. The remaining jobs that still call resolve-openci have their SHA advanced to the current base commit, keeping them consistent. The test.yml edits are pure text restoration with no behavioral impact.

No files require special attention. The bump-self-sha.sh script that originally caused the corruption is not modified here, so if it is still using awk '{print $NF}' on the manifest line it may corrupt text again on the next SHA bump — worth a follow-up fix there.

Important Files Changed

Filename Overview
.github/workflows/reusable-self-test.yml Removes the resolve-openci vendoring step from the actionlint job to eliminate false positives, and bumps the pinned SHA in three other jobs from 38435eb to 0fc8c78 (the PR base commit).
.github/workflows/test.yml Restores four instances of the word 'bootstrapping' that were corrupted to a 40-char SHA string by a faulty awk extraction in bump-self-sha.sh.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Before["actionlint job — BEFORE"]
        A1[Checkout source] --> B1[resolve-openci\nvendor .openci/ at old SHA]
        B1 --> C1[Install actionlint]
        C1 --> D1[Run actionlint]
        D1 --> E1["❌ False positives:\nold .openci/ actions have\ndifferent input names"]
    end

    subgraph After["actionlint job — AFTER"]
        A2[Checkout source] --> C2[Install actionlint]
        C2 --> D2[Run actionlint]
        D2 --> E2["✅ Checks current source\nagainst current composite actions"]
    end

    subgraph SHA["SHA Bump — other jobs"]
        F[resolve-openci step\n38435ebe → 0fc8c784\nbase commit of this PR]
    end
Loading

Reviews (1): Last reviewed commit: "fix(ci): fix actionlint CI failure and t..." | Re-trigger Greptile

- Remove resolve-openci from actionlint job in reusable-self-test.yml.
  The vendored .openci/ at a pinned SHA has different action input
  signatures than the current source, causing actionlint false positives
  about undefined inputs (anthropic-api-key, allowed-tools, openci-ref).

- Fix test.yml: the old AWK-based SHA extraction bug in bump-self-sha.sh
  replaced 'bootstra' with the full 40-char SHA in 4 locations (comments,
  descriptions, and step names). Restored original 'bootstrapping' text.
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@YiWang24, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 6 minutes and 40 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c4f4bf1-aaa8-4947-81f5-8f67048d2ae1

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc8c78 and 7155080.

📒 Files selected for processing (2)
  • .github/workflows/reusable-self-test.yml
  • .github/workflows/test.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/clean-actionlint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@YiWang24 YiWang24 merged commit 25bc024 into main May 26, 2026
10 of 16 checks passed
@YiWang24 YiWang24 deleted the fix/clean-actionlint branch May 26, 2026 04:33

@openbot-dev openbot-dev Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix corrupted text (hash replacing "bootstrapping") and bumps resolve-openci action ref to a newer commit.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant